Skip to content
This repository has been archived by the owner on Nov 6, 2021. It is now read-only.

Add Tests #31

Closed
seanmarcia opened this issue Oct 28, 2018 · 7 comments · Fixed by #39
Closed

Add Tests #31

seanmarcia opened this issue Oct 28, 2018 · 7 comments · Fixed by #39
Labels
good first issue Good for newcomers 🙋 Help Wanted Extra attention is needed

Comments

@seanmarcia
Copy link
Member

We spiked out a lot of functionality and consequently didn't include many tests. We'd love any help if people are interested!
@seanmarcia seanmarcia added 🙋 Help Wanted Extra attention is needed good first issue Good for newcomers Hacktoberfest labels Oct 28, 2018
@pakosaldanaort
Copy link
Contributor

pakosaldanaort commented Oct 29, 2018 •
edited

I'm interesting to collaborate with you @seanmarcia

@pakosaldanaort
Copy link
Contributor

What are the tests to do?

@seanmarcia
Copy link
Member Author

There is very little test coverage as we are rushing this app out the door. Any parts of the app that don't have tests that you feel like adding them would be appreciated!

@pakosaldanaort
Copy link
Contributor

ok @seanmarcia I will be working on that !

@tmr08c tmr08c mentioned this issue Oct 31, 2018
Merged
@pakosaldanaort
Copy link
Contributor

pakosaldanaort commented Nov 2, 2018 •
edited

Im working on that, why you closed this issue??? @seanmarcia

@seanmarcia
Copy link
Member Author

Sorry about this! It looks like it was automatically closed from the other PR! I've re-opened it! :)

@seanmarcia seanmarcia reopened this Nov 2, 2018
@pakosaldanaort pakosaldanaort mentioned this issue Nov 19, 2018
Merged
@seanmarcia
Copy link
Member Author

Closing in favour of #51

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers 🙋 Help Wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds request specs for the Partners API endpoint. tmr08c/partner
2 participants
@seanmarcia @pakosaldanaort