Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staff can pause pet applications #272

Closed
nsiwnf opened this issue Oct 14, 2023 · 11 comments · Fixed by #375
Closed

Staff can pause pet applications #272

nsiwnf opened this issue Oct 14, 2023 · 11 comments · Fixed by #375
Assignees

Comments

@nsiwnf
Copy link
Sponsor Collaborator

nsiwnf commented Oct 14, 2023

As staff, I can pause/unpause applications from the pets index screen

Mock:
Screen Shot 2023-10-14 at 11 26 39 AM

@Ptrboro
Copy link
Collaborator

Ptrboro commented Oct 15, 2023

Hey @nsiwnf, I think this can already be done, the option is just hidden in the dropdown. Do you want to pull this out of the dropdown and put it directly as a column instead?

Screenshot 2023-10-15 at 16 34 25

@nsiwnf
Copy link
Sponsor Collaborator Author

nsiwnf commented Oct 15, 2023

@Ptrboro Right, I think it would be better to move that out of the menu into a column. Currently the "pause applications" in the menu doesn't include a "pause_reason"

@kasugaijin
Copy link
Collaborator

kasugaijin commented Oct 15, 2023

@Ptrboro @nsiwnf I was debating whether we need a pause reason column any more. I am inclined to get rid of it. It made sense for one org with specific reasons, but now I think for many orgs just a simple pause feature works fine. Not saying the column needs to be removed in this PR if we agreed on that idea, but something to consider for the UI.

@nsiwnf
Copy link
Sponsor Collaborator Author

nsiwnf commented Oct 15, 2023

Ok great - either way, I think a toggle "pause application" column on the index page would be good, right?

@kasugaijin
Copy link
Collaborator

Yes I agree @nsiwnf

@aisayo
Copy link
Contributor

aisayo commented Oct 17, 2023

Hello, I would like to work on this.

I have a couple questions:

  1. I noticed the button redirects to the pets show page after the status of the application has been clicked. Do you want to maintain that behavior? I was thinking of updating the DOM dynamically for a better user experience.
  2. Is there a way to add custom css if necessary? I noticed in the photo provided, the toggle button has text content rendered from within the switch. I don't know that this is doable by just using bootstrap

@nsiwnf
Copy link
Sponsor Collaborator Author

nsiwnf commented Oct 17, 2023

@aisayo Great!

  1. I noticed the button redirects to the pets show page after the status of the application has been clicked. Do you want to maintain that behavior? I was thinking of updating the DOM dynamically for a better user experience.

Agreed - we dont need to redirect to the "show" page

  1. Is there a way to add custom css if necessary? I noticed in the photo provided, the toggle button has text content rendered from within the switch. I don't know that this is doable by just using bootstrap

Hm, I think we're trying to avoid custom css - go ahead and leave out the text or make any other changes that are supported by bootstrap/geeksui

@kasugaijin
Copy link
Collaborator

@aisayo how's this one going?

Copy link

github-actions bot commented Dec 6, 2023

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

Copy link

Automatically unassigned after 7 days of inactivity.

@github-actions github-actions bot removed the Stale label Dec 14, 2023
@jmilljr24
Copy link
Contributor

Can I be assigned to this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants