Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile Design: Staff Pets index table should render in cards below width xl: 1200px, #694

Closed
kasugaijin opened this issue May 8, 2024 · 4 comments
Assignees
Labels

Comments

@kasugaijin
Copy link
Collaborator

kasugaijin commented May 8, 2024

Currently on baja/staff/pets we render a table of pets. This is good for desktop, but not good for mobile. Instead, when the screen width is less than 1100 px 1200px (bootstrap class xl), we should render each pet in a card, similar to how we do at baja/adoptable_pets. We want to keep pagination for mobile.

Create a new partial (using partials/pet_card is easiest), that includes

  • the first image of the pet, if available, or the placeholder image,
  • the pet name,
  • sex,
  • breed,
  • and radio buttons for pause applications, and publish.

image

Acceptance criteria

  • pets are rendered in cards if width is less than 1200px, otherwise rendered in the table
@sarvaiyanidhi
Copy link
Contributor

Hi @kasugaijin I can work on this issue.. Can you please assign it? Thanks

@kasugaijin
Copy link
Collaborator Author

Sure thing!
I think for this we want to render both the table and the cards html at the same time but hide/show the correct markup for the screen width. Let me know if you have questions.

@sarvaiyanidhi
Copy link
Contributor

Sounds good.. Will implement accordingly to render card for screen width below 1100 px and otherwise table.

@kasugaijin kasugaijin changed the title Mobile Design: Staff Pets index table should render in cards below width 1100 px Mobile Design: Staff Pets index table should render in cards below width xl: 1200px, May 10, 2024
@kasugaijin
Copy link
Collaborator Author

Quick update @sarvaiyanidhi @jmilljr24 rightly pointed out that we should just use the bootstrap grid sizing here, so could you please set the transition between cards and table to bootstrap class xl which is 1,200 px

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants