Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heroku’s Next Chapter (2022) affects our review apps? #872

Open
tnir opened this issue Aug 26, 2022 · 14 comments
Open

Heroku’s Next Chapter (2022) affects our review apps? #872

tnir opened this issue Aug 26, 2022 · 14 comments

Comments

@tnir
Copy link
Collaborator

tnir commented Aug 26, 2022

https://blog.heroku.com/next-chapter

cf. #800

@tnir
Copy link
Collaborator Author

tnir commented Aug 26, 2022

@deivid-rodriguez Does it affect our review apps? It's not urgent though.

@deivid-rodriguez
Copy link
Member

I don't know, I hope not!

@tnir
Copy link
Collaborator Author

tnir commented Aug 26, 2022

So, you mean we are in Free plan?

@hsbt
Copy link
Member

hsbt commented Aug 26, 2022

The original post didn't say about review app. I'm not sure free usage includes review app with this Heroku changes.

@tnir
Copy link
Collaborator Author

tnir commented Aug 26, 2022

(New) Review Apps, currently used in this project, require free Dynos. We will not be able to use Heroku RA when free dynos are no more available.

@tnir
Copy link
Collaborator Author

tnir commented Aug 26, 2022

(We can use their open source support if we are in Free)

@simi
Copy link
Member

simi commented Aug 26, 2022

ℹ️ @hsbt offered transfer to Ruby OSS account if needed.

@tnir
Copy link
Collaborator Author

tnir commented Jan 1, 2023

We see failures in Heroku review apps in #1000 and #1002 etc.. Does any maintainers of @rubygems dig into this?

@deivid-rodriguez
Copy link
Member

No, so basically we need to upgrade our account to get review apps stable again, is that correct?

@hsbt
Copy link
Member

hsbt commented Jan 4, 2023

I can prepare it under the ruby organization.

@indirect
Copy link
Member

indirect commented Jan 4, 2023

I am not sure what is going on, exactly, since some Review Apps are working without any problem, like this one from #1066 https://bundler-site-pr-templat-tiztnn.herokuapp.com

@indirect
Copy link
Member

indirect commented Jan 4, 2023

On #929, the error message was Revision 80f9122a88c770a11726df4cd459c8b8acc7c166 does not exist in the repository https://github.com/tnir/middleman.git..

On #978 and #1065, both deployed successfully when I tried just now.

I have invited @tnir and @hsbt to the Heroku Pipeline, so hopefully you will be able to see any problems in the future. 👍🏻

@hsbt
Copy link
Member

hsbt commented Jan 4, 2023

Thanks, I'll investigate them.

@olleolleolle
Copy link
Member

Now, October 2023, are we using any Heroku Review apps? Are we on Netlify for the "review apps" now? (Can this Issue be closed?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants