This repository has been archived by the owner on Apr 14, 2021. It is now read-only.
Dependency type bug #1639
Merged
Dependency type bug #1639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…velopment dependencies declared in gemspecs.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the comments and so on, this is a bug occurring in 1.1 and 1.0, whereby the lockfile contains insufficient information to make Gem::Dependency#== match when the deployment mode checks to see if the lockfile resolve and the gemfile resolve match.
This means users receive an unexpected and otherwise unresolvable error that looks like this:
https://gist.github.com/605252169609bfe8081d
This patch also needs backporting to a bugfix release in 1.0. It's affecting our production deployments, and could easily affect others.
The only reason this /might/ be less common is that people with deployable applications often do not also publish those applications as importable gems. The behavior is incorrect, regardless of the leading use case.
Thanks!