Git sources don't respect the --quiet option

[stigi]

My Gemfile includes different gems via git.
When using bundler with the --quite option those gems still result in console output produced by git.
This is especially annoying when using bundler and capistrano.

Thanks :)

[rohitarondekar]

Confirm.

[indirect]

We can probably fix this just by passing -q to git in quiet mode.

On Nov 30, 2012, at 3:49 AM, Rohit Arondekar notifications@github.com wrote:

Confirm.

�
Reply to this email directly or view it on GitHub.

[rohitarondekar]

The updating part already passes --quiet as an option. That's why when I added a git dep to the existing --quiet test it was passing. If updating already uses the quiet option for Git can I just add the quiet option to clone also? :)

[indirect]

I think we are attempting to provide more feedback during the install process -- can you add quiet only if Bundler's quiet mode is on? Thanks. :)

On Nov 30, 2012, at 10:16 PM, Rohit Arondekar notifications@github.com wrote:

The updating part already passes --quiet as an option. That's why when I added a git dep to the existing --quiet test it was passing. If updating already uses the quiet option for Git can I just add the quiet option to clone also? :)

—
Reply to this email directly or view it on GitHub.

[rohitarondekar]

Hmm finding out whether the option quiet is set is not trivial unless I'm missing something. The creator of GitProxy is Git which in turn is created by the DSL. So it can't have access to the options passed to the CLI, right?

    def git(uri, options = {}, source_options = {}, &blk)
      unless block_given?
        msg = "sniped"
        raise DeprecatedError, msg
      end

      source Source::Git.new(_normalize_hash(options).merge("uri" => uri)), source_options, &blk
    end

Any ideas on how to proceed? One way might be to capture the output and output to screen via Bundler.ui so it obeys the quiet option.

[indirect]

You might be able to get the quiet value from Bundler.ui.quiet? (or write that method).

On Nov 30, 2012, at 11:11 PM, Rohit Arondekar notifications@github.com wrote:

Hmm finding out whether the option quiet is set is not trivial unless I'm missing something. The creator of GitProxy is Git which in turn is created by the DSL. So it can't have access to the options passed to the CLI, right?

def git(uri, options = {}, source_options = {}, &blk)
  unless block_given?
    msg = "sniped"
    raise DeprecatedError, msg
  end

  source Source::Git.new(_normalize_hash(options).merge("uri" => uri)), source_options, &blk
end

Any ideas on how to proceed? One way might be to capture the output and output to screen via Bundler.ui so it obeys the quiet option.

—
Reply to this email directly or view it on GitHub.

[rohitarondekar]

Merged #2194