Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

Improve OpenSSL load failure message #7596

Closed
deivid-rodriguez opened this issue Jan 23, 2020 · 1 comment
Closed

Improve OpenSSL load failure message #7596

deivid-rodriguez opened this issue Jan 23, 2020 · 1 comment

Comments

@deivid-rodriguez
Copy link
Member

deivid-rodriguez commented Jan 23, 2020

In #7527 we improved the message to show underlying error and backtrace.

However, we should also improve the other part of the message, namely:

You must recompile Ruby with OpenSSL support or change the sources in your Gemfile from 'https' to 'http'. Instructions for compiling with OpenSSL using RVM are available at https://rvm.io/packages/openssl.

This message doesn't add much value, so we should remove it entirely or maybe change it to something along the lines of:

Could not load OpenSSL, you ruby might not be compiled with OpenSSL support. The underlying error was #{error.class}: #{error}\n#{error.backtrace.join("\n ")}"

The reason is:

  • I don't think we want to explicitly recommend switching sources to http.
  • The RVM advice seems too specific to me, and it redirects to a page that's not very clear about how it helps to fix this issue.

Originally posted by @deivid-rodriguez in #7527

@deivid-rodriguez
Copy link
Member Author

This was completely fixed by #7597, so closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant