Skip to content
This repository has been archived by the owner on Apr 14, 2021. It is now read-only.

[Installer] Load gem plugins when installing #4954

Merged
merged 1 commit into from Oct 3, 2016

Conversation

segiddins
Copy link
Member

Closes #2824 I think

@indirect
Copy link
Member

@segiddins what's the difference between load_plugins and load_env_plugins, and why did you switch from one to the other?

@segiddins
Copy link
Member Author

Because that seemed to be what the issue was asking for

@indirect
Copy link
Member

@segiddins I am fairly certain it is not okay to remove load_plugins. Please either use both or research to figure out what the "right" (ha) answer is.

@segiddins
Copy link
Member Author

Where did I remove load_plugins? Honestly, if we don't know what www want to do, I'd rather not touch this. I was just making the exact change the linked issue asked for ¯_(ツ)_/¯

@indirect
Copy link
Member

I'm not comfortable accepting this until we understand the difference between load_plugins and load_env_plugins, so I'm sure that this change doesn't break anything.

@segiddins
Copy link
Member Author

load_plugins loads all rubygems plugins and is what rubygems does when invoked via its own CLI, load_env_plugins just loads plugins that are already on the $LOAD_PATH

@indirect
Copy link
Member

indirect commented Oct 3, 2016

@segiddins okay. I hope we don't regret this later when it turns out there are rubygems plugins that we don't actually want to load. 😅

@homu r+

@homu
Copy link
Contributor

homu commented Oct 3, 2016

📌 Commit 6d603e2 has been approved by indirect

homu added a commit that referenced this pull request Oct 3, 2016
…rect

[Installer] Load gem plugins when installing

Closes #2824 I think
@homu
Copy link
Contributor

homu commented Oct 3, 2016

⌛ Testing commit 6d603e2 with merge e11639f...

@homu
Copy link
Contributor

homu commented Oct 3, 2016

☀️ Test successful - status

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants