Use build-arg to set rubygems version #2548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonalkr132
force-pushed
the
rubygems-build-arg
branch
2 times, most recently
from
2b3aa04
to
8958cac
Compare
simi
approved these changes
Nov 9, 2020
simi
reviewed
Nov 9, 2020
Dockerfile
Outdated
| @@ -23,7 +25,7 @@ ADD https://s3-us-west-2.amazonaws.com/oregon.production.s3.rubygems.org/version | |||
| RUN mv /app/config/database.yml.example /app/config/database.yml | |||
|
|
|||
|
|
|||
| RUN gem install bundler io-console --no-ri --no-rdoc && \ | |||
| RUN gem install bundler io-console --no-rdoc && \ | |||
Fixes mismatch between expected gem version and installed gem version. As of now installed version of gem in prod is `3.0.3`, when we expect it to be 2.6.10. In Dockerfile in we were copying `/usr/local/bin/gem`, which is just a loader and doesn't decide rubygems version. Copying `/usr/local/lib/ruby/2.6.0/rubygem` from builder would most likely work but this seems unconventional and doesn't really save as much build time.
sonalkr132
force-pushed
the
rubygems-build-arg
branch
from
8958cac
to
3de1a20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mismatch between expected gem version and installed gem version.
As of now installed version of gem in prod is
3.0.3, when we expectit to be 2.6.10.
In Dockerfile in we were copying
/usr/local/bin/gem, which is justa loader and doesn't decide rubygems version.
Copying
/usr/local/lib/ruby/2.6.0/rubygemfrom builder would most likelywork but this seems unconventional and doesn't really save as much build time.