Reduce abusers rate limit to 40 rps and add rate limit on versions #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: CPU spikes on postgres. We had increased limits to 100 rps when we were having issues with info endpoint. we don't rate limit info at the moment, there limit need not be this high. Further, we had 100 rps at the time when we were running single nginx. With nginx on every pod, our rate limit was 100 * number of pods (replicas). versions was missing rate limit. added it for good measure. I have verified that our normal traffic doesn't need this high limits. Our original rate limits were 10 rps: https://github.com/rubygems/rubygems-chef/blob/master/cookbooks/rubygems-balancer/templates/default/site.conf.erb#L14
sonalkr132
added a commit
to sonalkr132/rubygems.org
that referenced
this pull request
Apr 26, 2021
Follow up to rubygems#2634 We were using combined rate limit of 20 rps before migrating to side-car nginx.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had increased limits to 100 rps when we were having issues with info endpoint. we don't rate limit info at the moment, these limit need not be this high. Further, we had 100 rps at the time when we were running single nginx. With nginx on every pod, our rate limit was 100 * number of pods (replicas).
versions was missing rate limit. added it for good measure.
I have verified that our normal traffic doesn't need this high limits.
Our original rate limits were 10 rps:
https://github.com/rubygems/rubygems-chef/blob/master/cookbooks/rubygems-balancer/templates/default/site.conf.erb#L14
We will further reduce this to 20 rps at the very least. just doing it in steps.