Use recommended to_utf8 method when comparing cert subject. #3197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
force-pushed
the
compare-utf8-subject
branch
from
d5e3d06
to
ff7e75a
Compare
Codecov Report
@@ Coverage Diff @@
## master #3197 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 110 110
Lines 3309 3309
=======================================
Hits 3249 3249
Misses 60 60 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
jenshenny
approved these changes
Sep 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ cherry-picked from https://github.com/rubygems/rubygems.org/pull/3188/files#diff-b21822a11515613ebb78cadf8e145857ba7121fe48d6f77df4da2f5a4c5cbfbc
ℹ️ makes it compatible with OpenSSL 3