Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to bundler 2.5.1 and add CHECKSUMS #4296

Merged
merged 4 commits into from Dec 16, 2023
Merged

Update to bundler 2.5.1 and add CHECKSUMS #4296

merged 4 commits into from Dec 16, 2023

Conversation

martinemde
Copy link
Member

There's a chance that we will have trouble during deploy, so maybe we should deploy this on its own.

@martinemde martinemde changed the title Update to bundler 2.5.1 and add CHEKCSUMS Update to bundler 2.5.1 and add CHECKSUMS Dec 15, 2023
Copy link

codecov bot commented Dec 15, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b1bb04e) 98.71% compared to head (b2802dd) 98.71%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4296   +/-   ##
=======================================
  Coverage   98.71%   98.71%           
=======================================
  Files         330      330           
  Lines        7343     7343           
=======================================
  Hits         7249     7249           
  Misses         94       94           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@segiddins
Copy link
Member

Mind if I also update the docker image, and have us on matching rubygems version as well?

@segiddins
Copy link
Member

❯ BUNDLE_FROZEN=1 bundle
Cannot write a changed lockfile while frozen.

@martinemde
Copy link
Member Author

@segiddins feel free to take this over if you want. I just wanted to get it started.

@martinemde
Copy link
Member Author

martinemde commented Dec 16, 2023

Seems like we need to skip checksums for now. (Edit: oh it's ok)

@segiddins segiddins merged commit 5ccdd50 into master Dec 16, 2023
14 checks passed
@segiddins segiddins deleted the update-bundler branch December 16, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants