Skip to content

Commit

Permalink
Lock rubocop version to 0.80.1
Browse files Browse the repository at this point in the history
The later RuboCop versions don't work with ruby2.3
so we should lock the version to what works with
ruby2.3 as we haven't dropped the support yet.

And since we're using the older version of rubocop,
also fix `Max` value of `LineLength` to 120, which
is the current standard. Without this, rubocop
will throw the line length offenses.

Signed-off-by: Utkarsh Gupta <utkarsh@debian.org>
  • Loading branch information
utkarsh2102 committed Jun 21, 2020
1 parent 83e330f commit 46d0a80
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 1 deletion.
3 changes: 3 additions & 0 deletions bundler/lib/bundler/templates/newgem/rubocop.yml.tt
Expand Up @@ -5,3 +5,6 @@ Style/StringLiterals:
Style/StringLiteralsInInterpolation:
Enabled: true
EnforcedStyle: double_quotes

Layout/LineLength:
Max: 120
2 changes: 1 addition & 1 deletion bundler/spec/commands/newgem_spec.rb
Expand Up @@ -177,7 +177,7 @@ def gem_skeleton_assertions

it "run rubocop inside the generated gem with no offenses" do
prepare_gemspec(bundled_app(gem_name, "#{gem_name}.gemspec"))
gems = ["rake", "rubocop"]
gems = ["rake", "rubocop -v 0.80.1"]
path = Bundler.feature_flag.default_install_uses_path? ? local_gem_path(:base => bundled_app(gem_name)) : system_gem_path
realworld_system_gems gems, :path => path
bundle "exec rubocop --ignore-parent-exclusion", :dir => bundled_app(gem_name)
Expand Down

0 comments on commit 46d0a80

Please sign in to comment.