Cached gem path resolution should consider default gems

rubygems · Oct 21, 2021 · 83b2b84 · 83b2b84
1 parent 8fe74a7
commit 83b2b84
Showing 1 changed file with 6 additions and 9 deletions.
diff --git a/bundler/lib/bundler/source/rubygems.rb b/bundler/lib/bundler/source/rubygems.rb
@@ -174,6 +174,7 @@ def install(spec, opts = {})
           Bundler.ui.confirm message
 
           path = cached_gem(spec)
+          raise GemNotFound, "Could not find #{spec.file_name} for installation" unless path
           if requires_sudo?
             install_path = Bundler.tmp(spec.full_name)
             bin_path     = install_path.join("bin")
@@ -233,11 +234,7 @@ def install(spec, opts = {})
       end
 
       def cache(spec, custom_path = nil)
-        if spec.default_gem?
-          cached_path = cached_built_in_gem(spec)
-        else
-          cached_path = cached_gem(spec)
-        end
+        cached_path = cached_gem(spec)
         raise GemNotFound, "Missing gem file '#{spec.file_name}'." unless cached_path
         return if File.dirname(cached_path) == Bundler.app_cache.to_s
         Bundler.ui.info "  * #{File.basename(cached_path)}"
@@ -352,11 +349,11 @@ def loaded_from(spec)
       end
 
       def cached_gem(spec)
-        cached_gem = cached_path(spec)
-        unless cached_gem
-          raise Bundler::GemNotFound, "Could not find #{spec.file_name} for installation"
+        if spec.default_gem?
+          cached_built_in_gem(spec)
+        else
+          cached_path(spec)
         end
-        cached_gem
       end
 
       def cached_path(spec)