Warn is licenses is empty. Fixes #202

rubygems · Mar 12, 2012 · ed1098d · ed1098d
1 parent 5806070
commit ed1098d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 5 deletions.
diff --git a/lib/rubygems/specification.rb b/lib/rubygems/specification.rb
@@ -485,8 +485,8 @@ def extra_rdoc_files
   #
   # The license must be a short name, no more than 64 characters.
   #
-  # This should just be the name of your license, make to include the full
+  # This should just be the name of your license. The full
-  # text of the license inside of the gem when you build it.
+  # text of the license should be inside of the gem when you build it.
   #
   # Usage:
   #   spec.license = 'MIT'
@@ -500,8 +500,8 @@ def license=o
   #
   # Each license must be a short name, no more than 64 characters.
   #
-  # This should just be the name of your license, make to include the full
+  # This should just be the name of your license. The full
-  # text of the license inside of the gem when you build it.
+  # text of the license should be inside of the gem when you build it.
   #
   # Usage:
   #   spec.licenses = ['MIT', 'GPL-2']
@@ -2386,6 +2386,8 @@ def validate packaging = true
       end
     }
 
+    alert_warning 'licenses is empty' if licenses.empty?
+
     # reject lazy developers:
 
     # FIX: Doesn't this just evaluate to "FIXME" or "TODO"?

diff --git a/test/rubygems/test_gem_commands_build_command.rb b/test/rubygems/test_gem_commands_build_command.rb
@@ -87,7 +87,7 @@ def util_test_build_gem(gem, gemspec_file)
     assert_equal "  Version: 2", output.shift
     assert_equal "  File: some_gem-2.gem", output.shift
     assert_equal [], output
-    assert_equal '', @ui.error
+    assert_equal "WARNING:  licenses is empty\n", @ui.error
 
     gem_file = File.join @tempdir, File.basename(gem.cache_file)
     assert File.exist?(gem_file)