Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small typo: There should be a trailing '.' character when trying to yank a gem that has already been yanked successfully prior. #1860

Closed
ghost opened this issue Mar 4, 2017 · 1 comment

Comments

@ghost
Copy link

ghost commented Mar 4, 2017

Typo:

When yanking a gem ("gemyank" is my alias), I got this:

gemyank beautiful_url --version 1.0.340

Output was:

"Yanking gem from https://rubygems.org...
beautiful_url 1.0.340 has already been deleted"

I would suggest a trailing '.' after the last part,
so instead I think it should be read:

"Yanking gem from https://rubygems.org...
beautiful_url 1.0.340 has already been deleted."

I know it is almost too trivial to report but since I
noticed it, I thought, why not report it, it may be
a simple fix. :)

@bronzdoc
Copy link
Member

I noticed this should be opened in rubygems/rubygems.org since rubygems is only printing the api response https://github.com/rubygems/rubygems/blob/master/lib/rubygems/commands/yank_command.rb#L90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant