Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing the default of bundle config set to be --local instead of --global #3926

Closed
eregon opened this issue Sep 2, 2020 · 2 comments · Fixed by #4152
Closed

Changing the default of bundle config set to be --local instead of --global #3926

eregon opened this issue Sep 2, 2020 · 2 comments · Fixed by #4152
Labels

Comments

@eregon
Copy link
Contributor

eregon commented Sep 2, 2020

Describe the problem as clearly as you can

bundle config set key value is currently --global by default (stored in ~/.bundle/config), while I think most usages would benefit from being local.

For instance, typical mistakes are bundle config path vendor/bundle, bundle config without db, etc.

Note also that the very similar command git config key value defaults to --local.

I think it would be much safer and intuitive to change bundle config set key value to also default to --local.
Most of Bundler configuration is project-specific and doing it globally makes often little sense, especially when not stating explicitly one wants it to be global.

Extracted from #3916

@eregon eregon added the Bundler label Sep 2, 2020
@eregon eregon changed the title Consider changing the default of bundle config set to be --local instead of --global Consider changing the default of bundle config set to be --local instead of --global Sep 2, 2020
@eregon eregon changed the title Consider changing the default of bundle config set to be --local instead of --global Changing the default of bundle config set to be --local instead of --global Sep 2, 2020
@eregon
Copy link
Contributor Author

eregon commented Sep 2, 2020

I think the user's expectation is that running pretty much any bundle command in a project with a Gemfile only affects that project, and nothing else.
I think system-wide changes such as global config should always be explicit, as otherwise they can be very confusing.

@eregon
Copy link
Contributor Author

eregon commented Feb 7, 2022

Thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant