-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Three tests fail in Fedora packaging environment #4429
Comments
Just FTR, the update is from 3.1.4 where the test suite was passing just fine with the Now trying to drop the option, different set of test cases fail, so the test suite is not passing with or without that option :/ |
Sure, feel free to propose a fix. Just make sure this test still fails if the patch that introduced it is reverted. |
The fix you proposed of adding |
Ah, now I just noticed that there are failing also other two test cases for similar reason. However, there was explicitly removed the |
I didn't know that you run tests like this at the time, so I thought it was not needed. Feel free to add it back. |
@deivid-rodriguez do we (want to) support tests running with |
I don't have a strong opinion, but if rubygems packagers want to keep that working in order to be able to run all tests without having to modify their copy of rubygems, I'm happy to accept contributions in that regard. |
Actually this is question also I have on my mind. I think that ruining the test suite with OTOH, this configuration is not tested. However, I have checked Fedora and it seems that it is possible to execute the test suite via |
The answer(s) to that question would be
No, since we don't test it and take no special care of not breaking it.
I don't have a strong opinion. If someone fixes it and adds some bare tests to keep it working, I wouldn't mind supporting it. |
Ah, now I have discovered that using |
That commit doesn't make much sense to me now 😅. |
Closing since we won't be fixing this as per #4440 (comment). |
Trying to update rubygems package on Fedora, I observe following error:
Digging deeper, this is the actual issue:
Since there is used
export RUBYOPT="--disable-gems -Ilib:test:bundler/lib"
prior the test execution this is not completely surprising and adding-rrubygems
into theOpen3
call fixes the situation. Now I wonder, is there a chance to have this fixed upstream?The text was updated successfully, but these errors were encountered: