Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle plugin install accepts --branch twice or more #5863

Open
tnir opened this issue Aug 23, 2022 · 0 comments
Open

bundle plugin install accepts --branch twice or more #5863

tnir opened this issue Aug 23, 2022 · 0 comments
Labels

Comments

@tnir
Copy link
Contributor

tnir commented Aug 23, 2022

Describe the problem as clearly as you can

bundle plugin install command allows users to pass --branch (or --ref) twice or more as below:

bundle plugin install --git https://github.com/rubygems/bundler-graph.git bundler-graph --branch v0.2.0 --branch v0.2.1

Which command did you run?

  1. bundle plugin install --git https://github.com/rubygems/bundler-graph.git bundler-graph --branch v0.2.0 --branch v0.2.1
  2. Same thing with --ref: bundle plugin install --git https://github.com/rubygems/bundler-graph.git bundler-graph --ref v0.2.0 --ref v0.2.1

What were you expecting to happen?

Warns if multiple --branch options are specified. Or exit as an error without installing plugin(s).

What actually happened?

Installs bundler-graph @ v0.2.1 without any warning or error.

Fetching https://github.com/rubygems/bundler-graph.git
Resolving dependencies...
Using bundler 2.4.0.dev
Using bundler-graph 0.2.1 from https://github.com/rubygems/bundler-graph.git (at v0.2.1@4fb866b)
Installed plugin bundler-graph

If not included with the output of your command, run bundle env and paste the output below

$ exe/bundle env
## Environment

```
Bundler             2.4.0.dev
  Platforms         ruby, x86_64-linux
Ruby                3.1.2p20 (2022-04-12 revision 4491bb740a9506d76391ac44bb2fe6e483fec952) [x86_64-linux]
  Full Path         /home/gitpod/.rvm/rubies/ruby-3.1.2/bin/ruby
  Config Dir        /etc
RubyGems            3.3.7
  Gem Home          /home/gitpod/.rvm/gems/ruby-3.1.2
  Gem Path          /home/gitpod/.rvm/gems/ruby-3.1.2:/home/gitpod/.rvm/rubies/ruby-3.1.2/lib/ruby/gems/3.1.0
  User Home         /home/gitpod
  User Path         /home/gitpod/.local/share/gem/ruby/3.1.0
  Bin Dir           /home/gitpod/.rvm/gems/ruby-3.1.2/bin
Tools               
  Git               2.37.1
  RVM               1.29.12 (latest)
  rbenv             not installed
  chruby            not installed
  rubygems-bundler  (1.4.5)
```

## Bundler Build Metadata

```
Built At          2022-08-23
Git SHA           73b5cf9bd
Released Version  false
```

## Bundler settings

```
path.system
  Set for your local app (/workspace/rubygems/.bundle/config): true
```

Derived from #5845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant