Validate more options for add sub-command #5905
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tnir
force-pushed
the
tnir-5904
branch
2 times, most recently
from
00db30a
to
ade2083
Compare
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
tnir
force-pushed
the
tnir-5904
branch
2 times, most recently
from
b0a6bc0
to
3c48bcf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The current option validator for
bundler-addwas not so helpful as many unnatural pairs are passed.Closes #5904
What is your fix for the problem, implemented in this PR?
Add more validations of the options
--git/--github/--branch/--refinbundle-addCLI command.Make sure the following tasks are checked
Resources
Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com