Add missing fileutils
require in rubygems installer
#4036
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When bundling a git gem including executables, the second time
bundle install
is run (when the gem has been cached), we would get a crash like:
What is your fix for the problem, implemented in this PR?
Bundler inherits from rubygems installer and uses this method directly. It can happen that
fileutils
is not yet required at that point.To repro the issue I needed to make sure that the executables inside dummy specs have the executable bit set. Otherwise a different code path that does require
fileutils
is run. This seems like a good thing anyways since it better resembles the real world.The fix is to add the missing require.
Make sure he following tasks are checked