Fix gem install vs gem fetch inconsistency
#5037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
toy
reviewed
Oct 30, 2021
deivid-rodriguez
force-pushed
the
fetch_vs_install
branch
from
1419d76
to
ed642d5
Compare
deivid-rodriguez
force-pushed
the
fetch_vs_install
branch
from
ed642d5
to
b3e9857
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2021
Fix `gem install` vs `gem fetch` inconsistency (cherry picked from commit f44f647)
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2021
Fix `gem install` vs `gem fetch` inconsistency (cherry picked from commit f44f647)
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2021
Fix `gem install` vs `gem fetch` inconsistency (cherry picked from commit f44f647)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Running
gem fetchandgem installagainst ageminaboxserver results in different fetched/installed gems when there are platform specific gems involved.What is your fix for the problem, implemented in this PR?
Use the same sort criteria in
gem fetchused elsewhere.Fixes #1629.
Make sure the following tasks are checked