Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring docs for gemfile(5) manpage up to date #6007

Merged
merged 1 commit into from Oct 25, 2022

Conversation

tnir
Copy link
Contributor

@tnir tnir commented Oct 23, 2022

What was the end-user or developer problem that led to this PR?

gemfile(5) manpage in Bundler is stale.

What is your fix for the problem, implemented in this PR?

  • Use updated Ruby/JRuby versions as examples as the current Bundler supports Ruby 2.3+.
  • Add mswin/mswin64 to platforms
  • Use TruffleRuby as example instead of Rubinius

Signed-off-by: Takuya Noguchi takninnovationresearch@gmail.com

Make sure the following tasks are checked

@tnir
Copy link
Contributor Author

tnir commented Oct 24, 2022

@deivid-rodriguez Could you check it out as the failed check on Actions looks irrelevant to this change to me.

@indirect
Copy link
Member

Thanks, this is great!

Since Bundler 2 requires a minimum Ruby version of 2.3.0, it seems like we can remove the docs (and I suppose also the implementation?) for the patchlevel: argument for the ruby DSL method.

@tnir tnir force-pushed the tnir-bundler-gemfile-5-ronn branch 2 times, most recently from 3764242 to 4801804 Compare October 25, 2022 04:46
@tnir tnir requested a review from indirect October 25, 2022 05:08
@tnir
Copy link
Contributor Author

tnir commented Oct 25, 2022

Since Bundler 2 requires a minimum Ruby version of 2.3.0, it seems like we can remove the docs (and I suppose also the implementation?) for the patchlevel: argument for the ruby DSL method.

I do not think at this moment we can remove this section from the docs since you know the implementation of patchlevel keyword argument for ruby DSL method in Gemfile. First, with this PR, we can update how it currently works and then we can remove implementation later and finally remove the doc for it.

@tnir
Copy link
Contributor Author

tnir commented Oct 25, 2022

#6012 was just created to discuss how we can deprecate/remove this legacy feature.

- Add mswin/mswin64 to platforms
- Use TruffleRuby as example instead of Rubinius

Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Co-authored-by: André Arko <andre@arko.net>
@tnir tnir force-pushed the tnir-bundler-gemfile-5-ronn branch from 4801804 to 5714069 Compare October 25, 2022 07:11
@deivid-rodriguez deivid-rodriguez changed the title Bundler: update docs for gemfile(5) manpage Bring docs for gemfile(5) manpage up to date Oct 25, 2022
@deivid-rodriguez
Copy link
Member

@tnir Can I merge this? I think that you force-pushed after my approval, so just wanted to make sure that it's ready.

@tnir
Copy link
Contributor Author

tnir commented Oct 25, 2022

@deivid-rodriguez Yes, please merge this PR. Just rebased the branch as you did not merge it after your approval 🙏

@deivid-rodriguez deivid-rodriguez merged commit b790b64 into rubygems:master Oct 25, 2022
@tnir tnir deleted the tnir-bundler-gemfile-5-ronn branch October 26, 2022 13:11
deivid-rodriguez added a commit that referenced this pull request Nov 2, 2022
Bring docs for gemfile(5) manpage up to date

(cherry picked from commit b790b64)
deivid-rodriguez added a commit that referenced this pull request Nov 2, 2022
Bring docs for gemfile(5) manpage up to date

(cherry picked from commit b790b64)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants