Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bundle outdated with both --groups and --parseable flags #6148

Merged
merged 1 commit into from Dec 19, 2022

Conversation

markburns
Copy link
Contributor

@markburns markburns commented Dec 18, 2022

What was the end-user or developer problem that led to this PR?

The bundle outdated command blows up when combining --groups and --parseable options

What is your fix for the problem, implemented in this PR?

Add a spec to replicate and fix the argument passed to the print_gems method.

Explanation: it seems this behaviour was untested and broken.

Fixes #6147.

Make sure the following tasks are checked

@welcome
Copy link

welcome bot commented Dec 18, 2022

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

@markburns markburns changed the title possible for for issue #6147 possible fix for issue #6147 Dec 18, 2022
@markburns markburns changed the title possible fix for issue #6147 Fix #6147 bundle outdated usage with --groups and --parseable flags Dec 18, 2022
@markburns markburns marked this pull request as ready for review December 18, 2022 18:03
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @markburns! Other than the lint error, this seems fine. I'll merge this as soon as the lint error is fixed ❤️

@markburns
Copy link
Contributor Author

Thanks @deivid-rodriguez. Should be fixed now.

Ironically found it tricky setting up rubocop due to gem dependency issues. Just manually installed the dependencies now to get working locally. Curious if there's any way to use bundler to build bundler.

@deivid-rodriguez deivid-rodriguez changed the title Fix #6147 bundle outdated usage with --groups and --parseable flags Fix bundle outdated with both --groups and --parseable flags Dec 19, 2022
@deivid-rodriguez
Copy link
Member

We do use a Gemfile to keep our development dependencies, and use Bundler to install them under the hood. You should run rake setup to install them. Did you run into any issues with that? I did have some issues with RSpec activation recently, but not with RuboCop.

@markburns
Copy link
Contributor Author

@deivid-rodriguez I see, yes that works fine now. I think it's a little unclear as that's at the top level of rubygems.
Whereas there's no mention of that at the /bundler level.

I went
from here -> to here -> then here

and I managed to avoid seeing rake setup

I would do a PR to improve the docs, but I am not sure I'm familiar enough yet with the process and setup to suggest it.

@simi
Copy link
Member

simi commented Dec 19, 2022

I would do a PR to improve the docs, but I am not sure I'm familiar enough yet with the process and setup to suggest it.

To update docs just find out related "ronn" file (maybe this one https://github.com/rubygems/rubygems/blob/master/bundler/lib/bundler/man/bundle-outdated.1.ronn?), do the change, render it to the man format (using rake man:build in bundler subfolder) and open PR with both files updated.

@deivid-rodriguez deivid-rodriguez merged commit 7dd88ab into rubygems:master Dec 19, 2022
@markburns markburns deleted the patch-1 branch December 19, 2022 11:03
@deivid-rodriguez
Copy link
Member

Thanks for the feedback and for this PR @markburns. I opened #6154 to improve our development setup docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NoMethodError from bundle outdated when combining --parseable and --groups
3 participants