Fix crash in pub grub involving empty ranges #6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, but I'll do it the other way around if you don't mind, just to make it clear that this particular change in pub grub fixes this particular bug. |
deivid-rodriguez
force-pushed
the
fix-bad-args
branch
from
73d0e73
to
0f16851
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 15, 2023
Fix crash in pub grub involving empty ranges (cherry picked from commit 95a802b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
This is another edge case surfacing an issue in pub grub upstream.
Some versions publish platform versions with incompatible Ruby support between each other. For example,
unf_extorgoogle-protobuf. If both are used in the same resolution, we may end up checking hash equality against empty ranges and causing a resolver crash.What is your fix for the problem, implemented in this PR?
Add the missing parameter in Pub Grub and get this edge case tested on our side.
Fixes #6326.
Make sure the following tasks are checked