Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto-heal corrupted Gemfile.lock with no specs #6423

Merged
merged 1 commit into from Mar 2, 2023

Conversation

duckinator
Copy link
Member

What was the end-user or developer problem that led to this PR?

If a Gemfile.lock has a mismatch between specs: and DEPENDENCIES, printing funding information runs what boils down to nil.metadata. This caused a NoMethodError to be raised.

What is your fix for the problem, implemented in this PR?

If the lockfile is malformed, it should be regenerated.

Make sure the following tasks are checked

@duckinator

This comment was marked as outdated.

@duckinator
Copy link
Member Author

It turns out the failing test is the one that #6400 changes. And with those changes merged first, it works fine.

So I think the solution is merging #6400 first, and I revise this based to be based on that PR.

@duckinator
Copy link
Member Author

I rebased off #6400, which is in the merge queue already. Once that's merged, I'll rebase off master again.

@duckinator duckinator marked this pull request as draft March 1, 2023 01:10
@deivid-rodriguez
Copy link
Member

Is it ready for a review now @duckinator? It looks good to me!

@duckinator
Copy link
Member Author

duckinator commented Mar 1, 2023 via email

@deivid-rodriguez deivid-rodriguez changed the title Avoid NoMethodError with malformed Gemfile.lock. (v2) Auto-heal corrupted Gemfile.lock with no specs Mar 1, 2023
@deivid-rodriguez deivid-rodriguez marked this pull request as ready for review March 1, 2023 22:15
@deivid-rodriguez deivid-rodriguez added this pull request to the merge queue Mar 1, 2023
@deivid-rodriguez
Copy link
Member

Done! Thanks for this @duckinator!

Merged via the queue into rubygems:master with commit 131085f Mar 2, 2023
deivid-rodriguez added a commit that referenced this pull request Mar 8, 2023
Auto-heal corrupted `Gemfile.lock` with no specs

(cherry picked from commit 131085f)
@duckinator duckinator deleted the gh-6280-v2 branch April 24, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants