Remove usage of Dir.chdir that only execute a subprocess #6930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
force-pushed
the
segiddins/remove-chdir
branch
from
ecf6678
to
7f56780
Compare
segiddins
changed the title
Preferring instead to spawn the subprocess in the correct directory
segiddins
force-pushed
the
segiddins/remove-chdir
branch
from
7f56780
to
ad5abd6
Compare
martinemde
approved these changes
Sep 1, 2023
| @@ -22,20 +22,23 @@ def gem(name, version = "1.0") | |||
|
|
|||
| def test_execute | |||
| @cmd.options[:args] = %w[foo] | |||
| @cmd.options[:editor] = "#{ruby_with_rubygems_in_load_path} -eexit --" | |||
| @cmd.options[:editor] = (ruby_with_rubygems_in_load_path + ["-e", "puts(ARGV,Dir.pwd)", "--"]).join(" ") | |||
There was a problem hiding this comment.
ShellWords.shelljoin maybe? Not a big deal.
|
Can’t use shelljoin because it isn’t shellsplit, it’s white space split in the command under testOn Sep 1, 2023, at 12:31 PM, Martin Emde ***@***.***> wrote:
@martinemde approved this pull request.
Nice cleanup.
In test/rubygems/test_gem_commands_open_command.rb:
@@ -22,20 +22,23 @@ def gem(name, version = "1.0")
def test_execute
@cmd.options[:args] = %w[foo]
- @cmd.options[:editor] = "#{ruby_with_rubygems_in_load_path} -eexit --"
+ @cmd.options[:editor] = (ruby_with_rubygems_in_load_path + ["-e", "puts(ARGV,Dir.pwd)", "--"]).join(" ")
ShellWords.shelljoin maybe? Not a big deal.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
|
I'm curious a little why |
|
yeah, rubocop is configured for hash rockets |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 13, 2023
Remove usage of Dir.chdir that only execute a subprocess (cherry picked from commit 10b2b5a)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 13, 2023
Remove usage of Dir.chdir that only execute a subprocess (cherry picked from commit 10b2b5a)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 13, 2023
Remove usage of Dir.chdir that only execute a subprocess (cherry picked from commit 10b2b5a)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Oct 16, 2023
Remove usage of Dir.chdir that only execute a subprocess (cherry picked from commit 10b2b5a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preferring instead to spawn the subprocess in the correct directory
What was the end-user or developer problem that led to this PR?
I noticed some usages of un-mutexed
Dir.chdircallsWhat is your fix for the problem, implemented in this PR?
Use
chdir:when spawning subprocessesMake sure the following tasks are checked