Improve recent force_ruby_platform fix
#7115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
approved these changes
Oct 26, 2023
Co-authored-by: Martin Emde <martin.emde@gmail.com>
deivid-rodriguez
force-pushed
the
improve-one-force-ruby-platform-spec
branch
from
5c6bc07
to
3e7f137
Compare
martinemde
approved these changes
Oct 28, 2023
simi
approved these changes
Oct 29, 2023
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2023
…m-spec Improve recent `force_ruby_platform` fix (cherry picked from commit 03213db)
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2023
…m-spec Improve recent `force_ruby_platform` fix (cherry picked from commit 03213db)
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2023
…m-spec Improve recent `force_ruby_platform` fix (cherry picked from commit 03213db)
deivid-rodriguez
added a commit
that referenced
this pull request
Nov 8, 2023
…m-spec Improve recent `force_ruby_platform` fix (cherry picked from commit 03213db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The developer problem is small:
What is your fix for the problem, implemented in this PR?
This PR iterates on #6936.
Feedback in the PR was not blocking, but I think it has merit to be introduced.
Make sure the following tasks are checked