Relax matching pattern for rake version #7123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deivid-rodriguez uhh, would be good to change the test to not rely on rack latest version somehow to not break those tests again with rake 14 🙏 |
|
Sure, or even better make those tests don't rely on the release schedule of real gems. Any improvements there super welcome! |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 8, 2023
Relax matching pattern for rake version (cherry picked from commit 5acec1a)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 8, 2023
Relax matching pattern for rake version (cherry picked from commit 5acec1a)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 8, 2023
Relax matching pattern for rake version (cherry picked from commit 5acec1a)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Nov 8, 2023
Relax matching pattern for rake version (cherry picked from commit 5acec1a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I released Rake 13.1.0 in last weekend. After that, some of bundler example is failing because they used
13.0pattern for checking version number.What is your fix for the problem, implemented in this PR?
I replaced it with
\dregex.Make sure the following tasks are checked