Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop remembering cli flags like --jobs or --retry in configuration #7191

Merged
merged 1 commit into from Nov 24, 2023

Conversation

deivid-rodriguez
Copy link
Member

@deivid-rodriguez deivid-rodriguez commented Nov 23, 2023

What was the end-user or developer problem that led to this PR?

We're still remembering CLI flags for backwards compatibility. However, this is only necessary for a few selected flags.

What is your fix for the problem, implemented in this PR?

Stop remembering flags like --jobs, or --retry.

This is stacked on top of #7189 and #7190.

Closes #7181.

Make sure the following tasks are checked

@deivid-rodriguez deivid-rodriguez changed the title Forget most cli options Stop remembering cli flags like --jobs or --retry in configuration Nov 23, 2023
Copy link
Member

@indirect indirect left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for doing this!

Copy link
Member

@martinemde martinemde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@deivid-rodriguez deivid-rodriguez merged commit 7b4e4b2 into master Nov 24, 2023
66 checks passed
@deivid-rodriguez deivid-rodriguez deleted the forget-most-cli-options branch November 24, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bundler project specific options
3 participants