Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Minitest::TestTask in a template file for minitest #7234

Merged
merged 1 commit into from Dec 8, 2023

Conversation

y-yagi
Copy link
Contributor

@y-yagi y-yagi commented Dec 8, 2023

What was the end-user or developer problem that led to this PR?

minitest has introduced a rake task for running test on 5.16.0. https://github.com/minitest/minitest/blob/master/History.rdoc#5160--2022-06-14-

This has some tasks related to running tests and it's useful for minitest users I think.
https://github.com/minitest/minitest#rake-tasks-

This PR changed to use the task in a template file for minitest

Make sure the following tasks are checked

`minitest` has introduced a rake task for running test on 5.16.0.
https://github.com/minitest/minitest/blob/master/History.rdoc#5160--2022-06-14-

This has some tasks related to running tests and it's useful for
`minitest` user I think.
https://github.com/minitest/minitest#rake-tasks-

This PR changed to use the task in a template file for `minitest`
@y-yagi y-yagi marked this pull request as ready for review December 8, 2023 02:52
Copy link
Member

@hsbt hsbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. TIL minitest/test_task has been introduced.

@hsbt hsbt merged commit 5387725 into rubygems:master Dec 8, 2023
66 checks passed
@y-yagi y-yagi deleted the minitest-testtask branch December 8, 2023 03:44
@y-yagi y-yagi restored the minitest-testtask branch December 8, 2023 03:44
@y-yagi y-yagi deleted the minitest-testtask branch December 8, 2023 03:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants