Let Bundler.with_original_env properly restore env variables originally empty
#7383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
segiddins
reviewed
Jan 16, 2024
|
I gave it a try and it fixes the issue I experienced. Thanks 🙇 |
deivid-rodriguez
force-pushed
the
properly-restore-empty-env-vars
branch
2 times, most recently
from
510d8b8
to
605bce3
Compare
deivid-rodriguez
force-pushed
the
properly-restore-empty-env-vars
branch
from
605bce3
to
54a853b
Compare
deivid-rodriguez
changed the title
Bundler.with_original_env properly restore env variables originally empty
Co-authored-by: Samuel Giddins <segiddins@segiddins.me>
deivid-rodriguez
force-pushed
the
properly-restore-empty-env-vars
branch
from
54a853b
to
d05b9e6
Compare
segiddins
approved these changes
Jan 25, 2024
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 5, 2024
Let `Bundler.with_original_env` properly restore env variables originally empty (cherry picked from commit f76d492)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Our
Bundler.with_original_envhelper does not properly restore empty ENV variables.What is your fix for the problem, implemented in this PR?
Just trying CI to tell me if there's a specific reason for it.
See #7365.
Make sure the following tasks are checked