Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Broken production deploy with mega mode #94

Closed
thepry opened this issue Dec 18, 2018 · 2 comments
Closed

Bug: Broken production deploy with mega mode #94

thepry opened this issue Dec 18, 2018 · 2 comments

Comments

@thepry
Copy link

thepry commented Dec 18, 2018

Apparently deploy script is using not defined fulL_cmd variable for compiling rails assets.

https://github.com/tongueroo/jets/blob/9b8dd19b948e0b16494673dd6031ff9cd3a5a10f/lib/jets/builders/code_builder.rb#L224

Traceback (most recent call last):
	22: from /Users/mac/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `<main>'
	21: from /Users/mac/.rvm/gems/ruby-2.5.3/bin/ruby_executable_hooks:24:in `eval'
	20: from /Users/mac/.rvm/gems/ruby-2.5.3/bin/jets:23:in `<main>'
	19: from /Users/mac/.rvm/gems/ruby-2.5.3/bin/jets:23:in `load'
	18: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/exe/jets:14:in `<top (required)>'
	17: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/cli.rb:5:in `start'
	16: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/cli.rb:21:in `start'
	15: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/base.rb:27:in `perform'
	14: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/base.rb:38:in `dispatch'
	13: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/thor-0.20.3/lib/thor.rb:387:in `dispatch'
	12: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/thor-0.20.3/lib/thor/invocation.rb:126:in `invoke_command'
	11: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/thor-0.20.3/lib/thor/command.rb:27:in `run'
	10: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/main.rb:21:in `deploy'
	 9: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/deploy.rb:29:in `run'
	 8: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/deploy.rb:50:in `build_code'
	 7: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/commands/build.rb:26:in `build_code'
	 6: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/builders/code_builder.rb:36:in `build'
	 5: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/builders/code_builder.rb:215:in `compile_rails_assets'
	 4: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/bundler-1.17.2/lib/bundler.rb:313:in `with_clean_env'
	 3: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/bundler-1.17.2/lib/bundler.rb:562:in `with_env'
	 2: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/bundler-1.17.2/lib/bundler.rb:313:in `block in with_clean_env'
	 1: from /Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/builders/code_builder.rb:216:in `block in compile_rails_assets'
/Users/mac/.rvm/gems/ruby-2.5.3/gems/jets-1.3.5/lib/jets/builders/code_builder.rb:224:in `rails_assets': undefined local variable or method `fulL_cmd' for #<Jets::Builders::CodeBuilder:0x00007f9ee1dc8638> (NameError)
@tongueroo
Copy link
Collaborator

Addressed in #96 Will go out shortly.

@tongueroo
Copy link
Collaborator

Will add this to the QA list.

Fixed and released in v1.3.6 CHANGELOG

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants