Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

write_buffer expects an argument in v1.1.1 #143

Closed
gmhawash opened this issue Mar 18, 2014 · 3 comments
Closed

write_buffer expects an argument in v1.1.1 #143

gmhawash opened this issue Mar 18, 2014 · 3 comments

Comments

@gmhawash
Copy link

It looks like you made an api change to write_buffer requiring an io argument; which is not compatible with the previous version. Typically a patch level modification should not change the api, and the documentation does not reflect this change.
@simonoff
Copy link
Member

Released 1.1.2 with hotfix.

@gmhawash
Copy link
Author

Great, thanks.

@cpence
Copy link

cpence commented Mar 25, 2014

The same bug is present in Zip::OutputStream, could you patch that one, too? Thanks!

@cpence cpence mentioned this issue Mar 25, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@simonoff @gmhawash @cpence