Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should Zip::File.new be private? #359

Open
hainesr opened this issue Apr 4, 2018 · 0 comments
Open

Should Zip::File.new be private? #359

hainesr opened this issue Apr 4, 2018 · 0 comments
Labels

Comments

@hainesr
Copy link
Member

hainesr commented Apr 4, 2018

It seems that Zip::File.new (initialize) is only really for use internally, by Zip::File.open, Zip::File.open_buffer and Zip::File.add_buffer.

Should it be removed from the public API? Either by making it explicitly private, or by removing it from the documentation?

It seems like it's pretty fragile if it's not called just right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant