New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OutputStream.write_buffer returns IOString with default encoding #438

Closed

henkesn opened this issue Feb 19, 2020 · 0 comments · Fixed by #439

Contributor

henkesn commented Feb 19, 2020 •

edited

In my case this is UTF-8, which produces encoding errors in encoding sensitive use cases.

I'd rather initialize the StringIO.new() in binmode which sets the encoding to ASCI-8BIT and prevents such errors, which are hard to find.

henkesn mentioned this issue

Set OutputStream.write_buffer's default buffer to binmode #439

Merged

jdleesmiller closed this as completed in #439

kitsunde mentioned this issue

RubyZip 2.3.0 changes workbook.stream encoding to ASCII-8BIT weshatheleopard/rubyXL#377

Closed

DDeBruler mentioned this issue

Return output stream in binmode caxlsx/caxlsx#120

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment