Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Coveralls to not report a failure on minor decreases of test coverage #491

Closed
jspanjers opened this issue Jun 6, 2021 · 1 comment
Assignees
Labels

Comments

@jspanjers
Copy link
Contributor

It seems most of the Coveralls test fails with a decreased coverage of 0.0%.
However, when I look at the Coveralls details, I do not notice any decreased coverage.
Maybe this is a rounding error?

Would it be possible to change the 'Coverage Decrease Threshold for failure' on https://coveralls.io/github/rubyzip/rubyzip/settings to something like, 0.1% ?

Yes, I hate Coveralls being so touchy by default, and I had no idea it could be adjusted! Also, while I like decent coverage, I'm not super bothered about it going up or down a bit when it's over 90% anyway. I'd be happy to have 90% as the threshold and then stop worrying about it. Unfortunately I don't have the required access to set this, as I'm not an owner of the rubyzip repo - maybe @jdleesmiller could set the threshold? Thanks!

Originally posted by @hainesr in #488 (comment)

@jdleesmiller
Copy link
Member

Agree that is annoying! I've set it to 0.5%.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants