Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adler32 checksum should be optional #3494

Open
davidgcameron opened this issue Apr 17, 2020 · 3 comments
Open

adler32 checksum should be optional #3494

davidgcameron opened this issue Apr 17, 2020 · 3 comments

Comments

@davidgcameron
Copy link
Contributor

Motivation

A community may decide to use md5 checksums instead of adler32, but using the generic schema, giving a None adler32 to the replica API is not allowed:

Rucio exception: Provided object does not match schema.
Details: Problem validating dids : None is not of type 'string'

Failed validating 'type' in schema['items']['properties']['adler32']:
    {'description': 'adler32',
     'pattern': '^[a-fA-F\\d]{8}$',
     'type': 'string'}

On instance[0]['adler32']:
    None

Modification

adler32 checksums should be optional at the schema level and also in the client API:

def add_replica(self, rse, scope, name, bytes, adler32, pfn=None, md5=None, meta={}):

@davidgcameron
Copy link
Contributor Author

In addition rucio list-file-replicas should show the checksum type that is stored instead of always adler32.

@gabrielefronze gabrielefronze self-assigned this Apr 17, 2020
@gabrielefronze
Copy link
Contributor

Hello @davidgcameron ,
I worked a bit on checksums in the past and I'll try to figure how to take care of this issue!
Cheers,

Gabriele

@bari12
Copy link
Member

bari12 commented Apr 17, 2020

The schema level can be done with a VO specific schema. But on the method level I agree we shouldn't require it.
Thanks @gabrielefronze 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants