Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebUI: Refine use of Datepicker widgets #4184 #4556

Conversation

dchristidis
Copy link
Contributor

Continuation from #4186.

There are multiple pages with Datepicker widgets in the Web UI. I’ve had this branch sitting around for quite a while where one of them is fixed. Before I move on to the others, could I ask for a quick look for obvious flaws?

@bari12 bari12 requested a review from tbeerman April 28, 2021 08:25
@mlassnig
Copy link
Contributor

@dchristidis status?

@maany maany linked an issue Dec 1, 2021 that may be closed by this pull request
@maany
Copy link
Member

maany commented Dec 1, 2021

@dchristidis does this still require further work?

@dchristidis dchristidis force-pushed the patch-4184-WebUI__Refine_use_of_Datepicker_widgets branch from baef800 to 3420063 Compare January 26, 2022 11:02
@dchristidis dchristidis marked this pull request as ready for review January 26, 2022 11:02
@dchristidis dchristidis removed the request for review from tbeerman January 26, 2022 11:02
@dchristidis dchristidis changed the title [WIP] WebUI: Refine use of Datepicker widgets #4184 WebUI: Refine use of Datepicker widgets #4184 Jan 26, 2022
@dchristidis dchristidis force-pushed the patch-4184-WebUI__Refine_use_of_Datepicker_widgets branch from 3420063 to 2b18d49 Compare February 4, 2022 12:48
Copy link
Member

@maany maany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, the code changes work well ;) Thanks @dchristidis

@bari12 bari12 merged commit c2b5171 into rucio:master Feb 4, 2022
@dchristidis dchristidis deleted the patch-4184-WebUI__Refine_use_of_Datepicker_widgets branch February 7, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Suspicious replicas page is misinterpreting the date picker
4 participants