New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove hardcoded references to rucio-ui-dev.cern.ch #5171
Comments
Can I take this up @maany @dchristidis @bari12? If so, do we want it to be extracted into a config file and then be replaced eventually or removed entirely? |
Sorry for the late reply, yes please go ahead 👍 |
Thank you! Just to confirm, I can extract this URL string out into maybe a config.json file and refer it from there? Would that be the desired way of implementation? |
Maybe an environment variable is better in this case ( to avoid creating a file with a single configuration variable). To completely resolve this issue, we'd also have to update the Helm Chart for the UI to allow people to provide this value to the UI containers and provide the documentation to the users so they are aware of this ;) . |
Thanks for this, will get to work right away! 👍 |
Passing environment variables into static .js files seem a little more complicated than I had expected. The environment variable would be accessible only to my flask server, which I would have to pass into my HTML templates, via render_template, and then pass it as a query parameter into the static .js files, and access it accordingly. Is there a better way? Let me know 😄 |
One way to get around this, would be to modify the docker The script should check if the environment variable for hostname is defined i.e. @bari12 what do you think? also, do you agree that we can use a new environment variable called |
Definitely a better way to solve this problem. Thanks for this! 👍 |
Sorry getting a bit late into this. I think you can just remove these entirely. No need to have this configurable etc. |
Motivation
It is expected that this node will cease to exist very soon.
Modification
The text was updated successfully, but these errors were encountered: