Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make monitoring able to use prometheus push gateway #6224

Closed
ericvaandering opened this issue May 24, 2023 · 0 comments · Fixed by #6230
Closed

Make monitoring able to use prometheus push gateway #6224

ericvaandering opened this issue May 24, 2023 · 0 comments · Fixed by #6230

Comments

@ericvaandering
Copy link
Contributor

Description

From a discussion with @rcarpa and @dchristidis :

@ericvaandering: What i would really like to be able to do with the current metrics is get access to the registry object so that these things could be pushed. I wonder if we could take a while to discuss this.

@rcarpa:
I don't think there is really a point to discuss it. Most infrastructure to use a custom registry is already there in rucio.core.monitor. Just add an optional registry argument in the constructor of MetricManager (if not set, defaults to REGISTRY) and pass it through to created metrics. You can also add a method to MetricManager to push to a pushgateway. Seems like a good idea. what do you think ?

@ericvaandering:
That's the thing. I don't see a registry in MetricManager, just in MulitMetric. Am I missing something? Otherwise, that plan is exactly what I would like.

@rcarpa:
There is none; but it can be (very easily) added if we want it there 😉

Motivation

No response

Change

No response

@ericvaandering ericvaandering self-assigned this May 24, 2023
@bari12 bari12 linked a pull request Jun 19, 2023 that will close this issue
@bari12 bari12 added this to the 1.31.5 milestone Jun 19, 2023
@bari12 bari12 closed this as completed Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment