Policies: refactor policy package code to use new plugin code #6382 #6426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bari12
previously approved these changes
Mar 7, 2024
|
@jamesp-epcc can you please rebase this and solve the conflict. |
jamesp-epcc
force-pushed
the
feature-6382-policy-package-algorithm-refactor
branch
2 times, most recently
from
ff591ec
to
489e7e7
Compare
jamesp-epcc
force-pushed
the
feature-6382-policy-package-algorithm-refactor
branch
from
489e7e7
to
eec177d
Compare
|
I've rebased and fixed the conflict. Also had to modify |
|
I see the integration tests failed, but I can't see an obvious connection with my changes. I'm wondering if this is one of the failures mentioned at the meeting yesterday. |
bari12
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the policy package algorithm code to use the new class introduced as part of the rule auto-approval work. All of the algorithm types (SURL, LFN2PFN and scope extraction) now use this base class, resulting in less duplication and hopefully cleaner code.
I have moved
plugins.pyfromcoretocommonto preserve the layering of the code, because the scope extraction algorithms are used client side.