Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify/Remove the public directory #67

Closed
3 tasks
maany opened this issue Aug 29, 2022 · 2 comments · Fixed by #80
Closed
3 tasks

Modify/Remove the public directory #67

maany opened this issue Aug 29, 2022 · 2 comments · Fixed by #80
Labels
DevOps Building, Testing/CI and Releasing of Rucio UI

Comments

@maany
Copy link
Member

maany commented Aug 29, 2022

Description

The public directory was initialized by create-react-app. It should be modified or removed.

Motivation

https://create-react-app.dev/docs/using-the-public-folder/

Change

Update the web app manifest: https://web.dev/add-manifest/

Additional Information

  • It is related to the Storybook?
  • It is related to the GitHub Actions?
  • It is related to the developer tools?
@maany maany added the DevOps Building, Testing/CI and Releasing of Rucio UI label Aug 29, 2022
@nimishbongale
Copy link
Member

Hey @maany

The public folder serves as a place to store static content/files for our storybook. build-storybook -o docs -s public is the command to build our storybook. Don't think doing away with it will be a good idea, as we certainly have static content being served. We can, however, rename it to something else if desired.

@nimishbongale
Copy link
Member

image

The public folder can't be done away with, but maybe it can be modified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DevOps Building, Testing/CI and Releasing of Rucio UI
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants