Why append the database to the modules path?

[davidwinter]

I don't understand why this is appending the database name to the migrations module path?

https://github.com/ruckus/ruckusing-migrations/blob/master/lib/Ruckusing/FrameworkRunner.php#L206

The migrations we use shouldn't be different per database. I want to write migrations for a module I'm using, and for those migrations to work across different databases.

Currently:

my_module/migrations/project_databasename/*.php
my_module/migrations/anotherproject_databasename/*.php

The migrations for these are identical, but currently duplicated.

Instead of:

my_module/migrations/*.php

Is this necessary? If not, can I propose we remove it? I'm happy to submit a PR.

[salimane]

some apps have different databases and you want to be able to group your migrations per database. In your case, if you don't want that feature, you could just use the directory parameter in config/database.inc.php . It will be empty in your case

'development' => array(
                        'type'      => 'mysql',
                        'host'      => 'localhost',
                        'port'      => 3306,
                        'database'  => 'ruckusing_migrations',
                        'user'      => 'root',
                        'password'  => '',
                        'directory' => '',
                        //'socket' => '/var/run/mysqld/mysqld.sock'
                ),

Thanks

[salimane]

@davidwinter please get the latest changes and report if you're still getting wrong migration directories.
Thanks