Outdated adapter for mysql #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 for mysqli |
|
Strange, project build was failed, but my succeeded. |
|
I will continue and implement PDO as optional common adapter. But within of another issue. |
|
I prefer PDO, that is more flexible then mysqli. |
|
Good idea. Yes, mysql is outdated. Are you still working on this or should I merge it? |
|
think it's ready for merge. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys.
I found that you use standard mysql adapter which called "mysql". It is a little bit awkward for the 2013 year =)
I will replace it for "mysqli" (will do it in 2 hours) or "PDO" (10 hours). What do you prefer?
That change will not affect requirements.