-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exception handlers set no exit code #95
Comments
Very good point. Thank you for the heads up! On Mar 20, 2013, at 8:01 AM, woru notifications@github.com wrote:
|
Please what was this trying to fix exactly ? can we have a way to reproduce this ? This changes introduces #96 . |
'success' is displayed even though migrations failed |
Here is a sample code I tested with pure php salimane at salimane-zenbook in ~
⚛ cat a.php
<?php
echo a;
salimane at salimane-zenbook in ~
⚛ php a.php
Notice: Use of undefined constant a - assumed 'a' in /home/salimane/a.php on line 3
Call Stack:
0.0226 373800 1. {main}() /home/salimane/a.php:0
PHP Notice: Use of undefined constant a - assumed 'a' in /home/salimane/a.php on line 3
PHP Stack trace:
PHP 1. {main}() /home/salimane/a.php:0
salimane at salimane-zenbook in ~
⚛ php a.php && echo "success"
Notice: Use of undefined constant a - assumed 'a' in /home/salimane/a.php on line 3
Call Stack:
0.0228 373800 1. {main}() /home/salimane/a.php:0
PHP Notice: Use of undefined constant a - assumed 'a' in /home/salimane/a.php on line 3
PHP Stack trace:
PHP 1. {main}() /home/salimane/a.php:0
success
salimane at salimane-zenbook in ~
⚛
Pure php is also showing that behavior. Thanks |
You example is invalid. Undefined variable results in a notice not error so result code 'success' is acceptable. |
please could you send a pull request.. |
Exception handlers set no exit code, which causes problems when migrations are called from bash scripts.
Fix:
The text was updated successfully, but these errors were encountered: