Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: modify delayLoad functionality #17

Merged
merged 22 commits into from Nov 29, 2022
Merged

feat!: modify delayLoad functionality #17

merged 22 commits into from Nov 29, 2022

Conversation

MoumitaM
Copy link
Contributor

Description

  • Delay load feature modified to delay not only the initialization of the SDK but also loading from the CDN
  • Added support for load option

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added unit tests for the code
  • I have made corresponding changes to the documentation

saikumarrs
saikumarrs reviewed Nov 18, 2022
View reviewed changes
src/gatsby-ssr.js Outdated Show resolved Hide resolved
src/gatsby-ssr.js Outdated Show resolved Hide resolved
src/gatsby-ssr.js Outdated Show resolved Hide resolved
src/gatsby-ssr.js Outdated Show resolved Hide resolved
src/gatsby-ssr.js Outdated Show resolved Hide resolved
@saikumarrs
Copy link
Member

Note that loadOptions support was already present in the plugin.

MoumitaM and others added 3 commits November 18, 2022 17:25
@MoumitaM @saikumarrs
Update src/gatsby-ssr.js
c742c33 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM @saikumarrs
Update src/gatsby-ssr.js
9d82636 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM
refactor: delayload logic
245f2f2
saikumarrs
saikumarrs requested changes Nov 23, 2022
View reviewed changes
gatsby-ssr.js Outdated Show resolved Hide resolved
gatsby-ssr.js Outdated Show resolved Hide resolved
gatsby-ssr.js Outdated Show resolved Hide resolved
@saikumarrs saikumarrs changed the title feat: delayLoad functionaliy modified and loadOptions support added feat!: modify delayLoad functionality Nov 23, 2022
@saikumarrs
Copy link
Member

Bump the version to 2.0.0.

MoumitaM and others added 11 commits November 23, 2022 11:16
@MoumitaM @saikumarrs
Update gatsby-ssr.js
c61c14d 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM @saikumarrs
Update gatsby-ssr.js
567f458 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM @saikumarrs
Update gatsby-ssr.js
3979180 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM
refactor: sdkSrc logic
bbe8d75
@MoumitaM
Version bumped
ecf49e0
@saikumarrs
chore: upgrade babel dependencies
fd7aa5a
@saikumarrs
fix: stop mutating loadOptions input
fece2f5
@saikumarrs
refactor: remove unused option
2c33aff
@saikumarrs
refactor: plugin options
9eb5987
@MoumitaM
chore: package-lock updated
48acb9d
@MoumitaM
Merge branch 'chore/loadType-syntax-update' of github.com:rudderlabs/…
2182a15 
…gatsby-plugin-rudderstack into chore/loadType-syntax-update
@saikumarrs
Copy link
Member

Update the README.md to reflect the current state.

saikumarrs
saikumarrs reviewed Nov 25, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
MoumitaM and others added 4 commits November 25, 2022 20:30
@MoumitaM @saikumarrs
Update README.md
931e848 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM @saikumarrs
Update README.md
aa17236 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM @saikumarrs
Update README.md
92df434 
Co-authored-by: Sai Kumar Battinoju <88789928+saikumarrs@users.noreply.github.com>
@MoumitaM
doc: readme updated
2b70e07
@MoumitaM MoumitaM changed the base branch from main to develop November 29, 2022 11:13
@MoumitaM MoumitaM merged commit 65f176d into develop Nov 29, 2022
@github-actions github-actions bot deleted the chore/loadType-syntax-update branch January 26, 2023 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@cwray-tech cwray-tech Awaiting requested review from cwray-tech

@bardisg bardisg Awaiting requested review from bardisg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MoumitaM @saikumarrs