Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fixed rudder_logger un-initialized issue #69

Merged
merged 9 commits into from Jan 4, 2023
Merged

fix: fixed rudder_logger un-initialized issue #69

merged 9 commits into from Jan 4, 2023

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented Dec 30, 2022 •
edited

Description of the change

  • Fixed Rudder Logger Un-initialized issue.
  • Updated Example App to contain multiple screens
  • Added Navigation Observer to the example app to fire screen calls automatically on screen change.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #51

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@desusai7 desusai7 self-assigned this Dec 30, 2022
@desusai7 desusai7 linked an issue Dec 30, 2022 that may be closed by this pull request
builder.withLogLevel & recordScreenViews not working on v2.1.1 #51
Closed
@bardisg
Copy link
Contributor

bardisg commented Dec 30, 2022

pr title should be lowercase only

@desusai7 desusai7 changed the title fix: Fixed Rudder Logger Un-initialized issue. fix: fixed rudder_logger un-initialized issue. Dec 30, 2022
@desusai7 desusai7 changed the title fix: fixed rudder_logger un-initialized issue. fix: fixed rudder_logger un-initialized issue Dec 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jan 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@bardisg bardisg merged commit 118fb52 into develop Jan 4, 2023
@github-actions github-actions bot deleted the fix/logger_and_screenviews branch March 5, 2023 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsdebs itsdebs itsdebs approved these changes

@pallabmaiti pallabmaiti pallabmaiti approved these changes

@bardisg bardisg bardisg approved these changes

Assignees

@desusai7 desusai7

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

builder.withLogLevel & recordScreenViews not working on v2.1.1
4 participants
@desusai7 @bardisg @itsdebs @pallabmaiti