fixed warning for pod lint

rudderlabs · Dec 12, 2019 · f230ce2 · f230ce2
1 parent 8993856
commit f230ce2
Show file tree

Hide file tree

Showing 4 changed files with 14 additions and 5 deletions.
diff --git a/RudderSDKCore.podspec b/RudderSDKCore.podspec
@@ -1,6 +1,6 @@
 Pod::Spec.new do |spec|
   spec.name         = "RudderSDKCore"
-  spec.version      = "0.1.5"
+  spec.version      = "0.1.6"
   spec.summary      = "Privacy and Security focused Segment-alternative. iOS SDK"
   spec.description  = <<-DESC
 Rudder is a platform for collecting, storing and routing customer event data to dozens of tools. Rudder is open-source, can run in your cloud environment (AWS, GCP, Azure or even your data-centre) and provides a powerful transformation framework to process your event data on the fly.
@@ -9,7 +9,7 @@ Rudder is a platform for collecting, storing and routing customer event data to
   spec.license      = { :type => "Apache", :file => "LICENSE" }
   spec.author             = { "Rudderlabs" => "arnab@rudderlabs.com" }
   spec.platform     = :ios, "9.0"
-  spec.source       = { :git => "https://github.com/rudderlabs/rudder-sdk-ios.git" :tag => "v0.1.6"}
+  spec.source       = { :git => "https://github.com/rudderlabs/rudder-sdk-ios.git", :tag => "v0.1.6"}
   spec.source_files  = "Classes", "RudderSDKCore/**/*.{h,m}"
   spec.ios.deployment_target = '8.0'
 end
diff --git a/...xcodeproj/project.xcworkspace/xcuserdata/arnab.xcuserdatad/UserInterfaceState.xcuserstate b/...xcodeproj/project.xcworkspace/xcuserdata/arnab.xcuserdatad/UserInterfaceState.xcuserstate
diff --git a/...e/RudderSDKCore.xcodeproj/xcuserdata/arnab.xcuserdatad/xcschemes/xcschememanagement.plist b/...e/RudderSDKCore.xcodeproj/xcuserdata/arnab.xcuserdatad/xcschemes/xcschememanagement.plist
@@ -7,7 +7,7 @@
 		<key>RudderSDKCore.xcscheme_^#shared#^_</key>
 		<dict>
 			<key>orderHint</key>
-			<integer>1</integer>
+			<integer>0</integer>
 		</dict>
 	</dict>
 </dict>

diff --git a/RudderSDKCore/RudderSDKCore/RudderServerConfigManager.m b/RudderSDKCore/RudderSDKCore/RudderServerConfigManager.m
@@ -81,7 +81,11 @@ - (RudderServerConfigSource *)_parseConfig:(NSString *)configStr {
         NSDictionary *sourceDict = [configDict objectForKey:@"source"];
         NSString *sourceId = [sourceDict objectForKey:@"id"];
         NSString *sourceName = [sourceDict objectForKey:@"name"];
-        BOOL isSourceEnabled = [sourceDict objectForKey:@"enabled"];
+        NSNumber *sourceEnabled = [sourceDict valueForKey:@"enabled"];
+        BOOL isSourceEnabled = NO;
+        if (sourceEnabled != nil) {
+           isSourceEnabled = [sourceEnabled boolValue];
+        }
         NSString *updatedAt = [sourceDict objectForKey:@"updatedAt"];
         source = [[RudderServerConfigSource alloc] init];
         source.sourceId = sourceId;
@@ -96,7 +100,12 @@ - (RudderServerConfigSource *)_parseConfig:(NSString *)configStr {
             RudderServerDestination *destination = [[RudderServerDestination alloc] init];
             destination.destinationId = [destinationDict objectForKey:@"id"];
             destination.destinationName = [destinationDict objectForKey:@"name"];
-            destination.isDestinationEnabled =[destinationDict objectForKey:@"enabled"];
+            NSNumber *destinationEnabled = [destinationDict objectForKey:@"enabled"];
+            BOOL isDestinationEnabled = NO;
+            if (destinationEnabled != nil) {
+                isDestinationEnabled = [destinationEnabled boolValue];
+            }
+            destination.isDestinationEnabled = isDestinationEnabled;
             destination.updatedAt = [destinationDict objectForKey:@"updatedAt"];
 
             RudderServerDestinationDefinition *destinationDefinition = [[RudderServerDestinationDefinition alloc] init];