New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: made reset and identify api's synchronous to reflect the data immediately #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pallabmaiti
previously approved these changes
Mar 10, 2023
desusai7
force-pushed
the
feat/sync_identify_reset_api
branch
from
March 13, 2023 12:58
d4f0edf
to
c821955
Compare
pallabmaiti
suggested changes
Mar 14, 2023
pallabmaiti
approved these changes
Mar 15, 2023
Kudos, SonarCloud Quality Gate passed! |
pallabmaiti
pushed a commit
that referenced
this pull request
Mar 27, 2023
…mmediately (#284) * feat: made reset and identify api's synchronous to reflect the data immediately * chore: updated RSContext Headerfile * refactor: made rscontext queue private and other classes to use their own queue * fix: made setConsentData synchronous and few minor changes * test: added unit tests for RSContext.m * test: fixed minor issues in unit test cases for RSContext * fix: made return type as nullable for applicable methods in RSContext.m * test: fixed issues with nil return type in unit test cases * chore: minor refactoring and issue fixes * refactor: optimized the test case for setting consent data * ci: added workflows for making a beta release * chore: bumped version to 1.13.0.beta.2 --------- Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made reset and identify api's synchronous to reflect the data immediately