Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: made reset and identify api's synchronous to reflect the data immediately #284

Merged
merged 15 commits into from Mar 27, 2023

Conversation

desusai7
Copy link
Contributor

@desusai7 desusai7 commented Mar 2, 2023

Made reset and identify api's synchronous to reflect the data immediately

pallabmaiti
pallabmaiti previously approved these changes Mar 10, 2023
@desusai7 desusai7 force-pushed the feat/sync_identify_reset_api branch from d4f0edf to c821955 Compare March 13, 2023 12:58
Tests/RSContextTests.swift Outdated Show resolved Hide resolved
Tests/RSContextTests.swift Outdated Show resolved Hide resolved
Tests/RSContextTests.swift Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

71.2% 71.2% Coverage
0.0% 0.0% Duplication

@desusai7 desusai7 merged commit 6ff743a into develop Mar 27, 2023
6 checks passed
pallabmaiti pushed a commit that referenced this pull request Mar 27, 2023
…mmediately (#284)

* feat: made reset and identify api's synchronous to reflect the data immediately

* chore: updated RSContext Headerfile

* refactor: made rscontext queue private and other classes to use their own queue

* fix: made setConsentData synchronous and few minor changes

* test: added unit tests for RSContext.m

* test: fixed minor issues in unit test cases for RSContext

* fix: made return type as nullable for applicable methods in RSContext.m

* test: fixed issues with nil return type in unit test cases

* chore: minor refactoring and issue fixes

* refactor: optimized the test case for setting consent data

* ci: added workflows for making a beta release

* chore: bumped version to 1.13.0.beta.2

---------

Co-authored-by: Desu Sai Venkat <desusaivenkat@Desus-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants